Re: Proposal for Signal Detection Refactoring

On Thu, Jan 17, 2019 at 7:08 PM Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On 2018-10-09 16:04:35 +0200, Peter Eisentraut wrote:
> > More generally, I'd like this material to be code comments. It's the
> > kind of stuff that gets outdated before long if it's kept separate.
>
> I'm not sure I buy this here - we don't have (but perhaps should?) a
> convenient location for an overview comment around this. There's no
> "signal_handling.c" where it'd clearly belong - given the lack of a
> clear point to look to, I don't think a README.SIGNAL_HANDLING would get
> out-of-date more quickly than code comments in mildly related place (say
> postgres.c or miscinit.c) would get out of date at a different pace.
>

The other point is that "This is the way to do it" is a little easier when
in a README rather than in code comments sine those might be scattered in a
bunch of different places.

>
> Greetings,
>
> Andres Freund
>

--
Best Regards,
Chris Travers
Head of Database

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com
Saarbrücker Straße 37a, 10405 Berlin