Re: [PATCH] ALTER TABLE ... SET STORAGE default

From: Nikita Malakhov <hukutoc(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] ALTER TABLE ... SET STORAGE default
Date: 2022-08-22 19:41:33
Message-ID: CAN-LCVP6qrS-9icHNmv1qfmQRBE-XG3udDHiOTg6n7kTBzTVnA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

Anyway, adding a paragraph with default storage mode for each standard data
type seems
like a good idea and I'd prepare a patch for it.
Thank you!

On Mon, Aug 22, 2022 at 4:28 PM Aleksander Alekseev <
aleksander(at)timescale(dot)com> wrote:

> Hi Nikita,
>
> > This seems a little bit confusing and thus very unfriendly for the user,
> because the actual meaning
> > of the same 'DEFAULT' option will be different for each data type, and
> to check storage mode user
> > has to query full table (or column) description.
> > I'd rather add a paragraph in documentation describing each data type
> default storage mode.
>
> I agree that "SET STORAGE default" syntax leaves much to be desired.
>
> Personally I would prefer "RESET STORAGE" and "RESET COMPRESSION". But
> since we already have "SET COMPRESSION default" this going to be
> either two commands that do the same thing, or a broken backward
> compatibility. Simply removing "SET COMPRESSION default" will make the
> syntax consistent too, but again, this would be a broken backward
> compatibility. I would argue that a sub-optimal but consistent syntax
> that does the job is better than inconsistent syntax and figuring out
> the default storage strategy manually.
>
> But let's see what is others people opinion.
>
> --
> Best regards,
> Aleksander Alekseev
>

--
Regards,
Nikita Malakhov
https://postgrespro.ru/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-08-22 20:16:15 Re: making relfilenodes 56 bits
Previous Message Ranier Vilela 2022-08-22 19:15:23 re: Change pfree to accept NULL argument