| From: | Nikita Malakhov <hukutoc(at)gmail(dot)com> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Cc: | Jan Katins <jasc(at)gmx(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Smith <smithpb2250(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: POC: Extension for adding distributed tracing - pg_tracing |
| Date: | 2024-02-09 16:46:58 |
| Message-ID: | CAN-LCVOGcGK-eDfL2r3GeZE1v04zuc4VPdWWei8+jHHKzm7YtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
I agree with Heikki on most topics and especially the one he recommended
to publish your extension on GitHub, this tool is very promising for highly
loaded
systems, you will get a lot of feedback very soon.
I'm curious about SpinLock - it is recommended for very short operations,
taking up to several instructions, and docs say that for longer ones it
will be
too expensive, and recommends using LWLock. Why have you chosen SpinLock?
Does it have some benefits here?
Thank you!
PS: process_query_desc function has trace_context argument that is neither
used nor passed anywhere.
--
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company
https://postgrespro.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amonson, Paul D | 2024-02-09 17:39:46 | RE: Popcount optimization using AVX512 |
| Previous Message | Nathan Bossart | 2024-02-09 16:36:57 | Re: [PATCH] allow pg_current_logfile() execution under pg_monitor role |