Redundant psql tab-completion for CREATE PUBLICATION

From: Edmund Horner <ejrh00(at)gmail(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Redundant psql tab-completion for CREATE PUBLICATION
Date: 2018-05-29 12:58:07
Message-ID: CAMyN-kDe=gBmHgxWwUUaXuwK+p+7g1vChR7foPHRDLE592nJPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While looking at Justin's patch for VACUUM completions, I found an
existing bit of code that tries to match on a word with a space:

/* Complete "CREATE PUBLICATION <name> FOR TABLE <table>" */
else if (Matches4("CREATE", "PUBLICATION", MatchAny, "FOR TABLE"))
COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, NULL);

I think the clause will never match the "FOR TABLE" word; and can, in
any case, be removed, as the the final check for completable "things"
(at the end of psql_completion) will see "TABLE" and act
appropriately.

Here's a little patch to remove these lines.

Edmund

Attachment Content-Type Size
remove-redundant-create-publication-completion.patch application/octet-stream 785 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Manuel Kniep 2018-05-29 13:19:38 PATCH pass PGOPTIONS to pg_regress
Previous Message Edmund Horner 2018-05-29 12:45:30 Re: adding tab completions