Re: pgbench doc typos

From: Edmund Horner <ejrh00(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench doc typos
Date: 2018-03-30 07:30:51
Message-ID: CAMyN-kCHTxa=wBfBxk0eBqqdLwTrUovtwE7iHrFnmRKj4n1hLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30 March 2018 at 19:26, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> Thanks for the check. You might consider turning the patch as ready in the
> cf app.

Ok, I have done so, since the patch is small and simple.

>> Fixing the abs/hash bracketing seems clear. The wasn't sure about
>> rewriting "mod(i, bj)" as "mod(i, j)", because there could be some
>> convention about parameter names, but I can't think of anything the "b"
>> could be in the case of mod.
>
>
> Might be a left-over a previous version which might have used MOD(a, b), but
> a/b are rather used for fp numbers and i/j for integers.

Ah that seems possible.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2018-03-30 07:38:44 Re: Feature Request - DDL deployment with logical replication
Previous Message Konstantin Knizhnik 2018-03-30 07:26:16 Re: Feature Request - DDL deployment with logical replication