Re: doc: Document how to run regression tests with custom server settings

From: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, "peter(at)eisentraut(dot)org" <peter(at)eisentraut(dot)org>
Subject: Re: doc: Document how to run regression tests with custom server settings
Date: 2021-06-30 02:15:25
Message-ID: CAMsr+YHfNzQFxBtHnS_L=MBsd_H-N4+Ff4WJZ7gwZenPbqOwJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Mon, 21 Jun 2021 at 15:43, tanghy(dot)fnst(at)fujitsu(dot)com <
tanghy(dot)fnst(at)fujitsu(dot)com> wrote:

> Hi
>
> I was doing regression testing according to the PG-doc at [1].
> The modification at 854434c5 seems not correct, could you please take a
> check at it?
>
> >make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"
>
> The above command reported an error like this:
> failed: FATAL: parameter "log_checkpoints" cannot be changed now
>
> IMHO, as a sighup GUC, log_checkpoints can't be set in PGOPTIONS, is that
> correct?
>
> >make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"
>
> pg_regress: could not open "test_postgresql.conf" to read extra config: No
> such file or directory
>
> I fixed above problem using command like this:
> make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"
>
> Maybe we can change doc description to tell user he/she should specify the
> location of " test_postgresql.conf", thoughts?
>
> [1] https://www.postgresql.org/docs/devel/regress-run.html

Yes, that'd make a lot of sense.

PGOPTIONS is more suited for client settings.

Willing to cook up a quick patch?

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Fujii Masao 2021-06-30 10:37:39 Re: add argument type to postgres_fdw docs
Previous Message David G. Johnston 2021-06-28 15:46:02 Re: Document behaviour of failed sub queries