| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> |
| Cc: | List <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: executebatch: |
| Date: | 2015-10-07 11:43:19 |
| Message-ID: | CAMsr+YHdHiZC3A+fa4dTpFWRUN-ec7pAQp--XVqdkFCJDv29rA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
For the record, fixed by Vladimir in
https://github.com/pgjdbc/pgjdbc/pull/380 after comment discussion on
https://github.com/pgjdbc/pgjdbc/commit/a6bd36faaedc779f932fa76f52bab9550f0fcd6d#diff-54e833c3fd25410b800ff28a1e189227R97
On 2 October 2015 at 21:29, Vladimir Sitnikov
<sitnikov(dot)vladimir(at)gmail(dot)com> wrote:
> Hi,
>
> I'm observing a performance degradation in executeBatch case when
> upgrading 9.3-1102.jdbc41 -> 9.4-1203.
>
> 1102 -- 0.78 sec / executeBatch
> 1203 -- 1.8 sec / executeBatch
>
> It looks like the degradation is caused by the fact that two "flag"
> constants share the same value:
> QUERY_FORCE_DESCRIBE_PORTAL = 128; and QUERY_DISALLOW_BATCHING = 128;
> https://github.com/pgjdbc/pgjdbc/commit/a6bd36faaedc779f932fa76f52bab9550f0fcd6d#diff-54e833c3fd25410b800ff28a1e189227R97
> https://github.com/pgjdbc/pgjdbc/commit/a6bd36faaedc779f932fa76f52bab9550f0fcd6d#diff-54e833c3fd25410b800ff28a1e189227R106
>
> Profiling shows that 1203 does QueryExecutorImpl.flushIfDeadlockRisk
> -> sendSync a lot.
>
> I wonder if reusing 128 was intentional or not.
> I'll try modifying QUERY_FORCE_DESCRIBE_PORTAL=512 to see if that helps.
>
> --
> Regards,
> Vladimir Sitnikov
>
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2015-10-07 11:51:10 | Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; " |
| Previous Message | Tom Smith | 2015-10-03 23:47:44 | latest jdbc release |