Re: TAP / recovery-test fs-level backups, psql enhancements etc

On 1 March 2016 at 22:08, salvador fandino <sfandino(at)gmail(dot)com> wrote:

>
>
> On Tue, Mar 1, 2016 at 2:48 PM, Craig Ringer <craig(at)2ndquadrant(dot)com>
> wrote:
>
>>
>> Hi all
>>
>> I've been working with the new TAP tests for recovery and have a number
>> of enhancements I'd like to make to the tooling to make writing tests
>> easier and nicer. I've also included two improvements proposed by Kyotaro
>> HORIGUCHI in the prior thread about the now-committed TAP recovery tests.
>>
>> I developed these changes as part of testing failover slots and logical
>> decoding timeline following, where I found a need for better control over
>> psql, the ability to make filesystem level backups, etc. It doesn't make
>> sense to try to jam all that into my test script when it belongs in the
>> infrastructure.
>>
>> Patches attached, each explains what it does and what for.
>>
>
> You are using both "die_on_error" and "on_error_die" in your code. That
> looks like a mismatch!
>

Thanks for taking a look.

In this case it has no effect since it's just specifying the default
explicitly, but it's certainly wrong. Fixed in git.

I'll wait to see what else comes up before posting another series.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services