| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | TAP: fix undefined var warnings in PostgresNode with timeout |
| Date: | 2017-04-12 12:13:43 |
| Message-ID: | CAMsr+YGqOdSXQfa8jX3k=dgii+FpVy07upbAEhfpPLWREc_SJQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
If PostgresNode::psql (from the TAP framework) is called with a
timeout set and a timed_out reference, it will attempt to do bitwise
AND and bitshifts on the $ret value from IPC::Run, which is undef if
the command timed out.
This produces annoying errors in the logs.
Fix attached. Should be applied to 9.6 and pg 10.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| undefined-psql-timeout-96.patch | text/x-patch | 1.8 KB |
| undefined-psql-timeout-pg10.patch | text/x-patch | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-04-12 12:23:35 | Re: TAP tests take a long time |
| Previous Message | Tom Lane | 2017-04-12 12:04:21 | Re: index-only count(*) for indexes supporting bitmap scans |