Re: Document how to set up TAP tests for Perl 5.8.8

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: Document how to set up TAP tests for Perl 5.8.8
Date: 2016-11-17 02:42:54
Message-ID: CAMsr+YG_S+kAvcSoaOKfVeFgG2An_D+NSap7H3HCV+hTRduPWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17 November 2016 at 10:31, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:

>
> I vote +1 to upgrading perl, but I'm not sure if all supporting
> platforms other than linux support the version of perl.
>
> Anyway ./configure is saying as the following.
>
> | *** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
> | *** Perl version 5.8 or later is required, but this is $pgac_perl_version." >&5
>
> If TAP test requires 5.8.8, the whole build sequence should
> follow that. Or at least ./configure --enable-tap-tests should
> check that.

I wrote 5.8.8 because that's what we've always discussed before and I
could honestly not imagine it mattering whether we require 10-year or
15-year old Perl. Especially for the TAP tests, which are new, and
optional.

I really don't think it matters if the TAP tests use a slightly newer
Perl. They're optional and not enabled by default. Can we just
document this please? I didn't think a four-line docs patch to an
optional, non-default, new test suite would require this kind of
discussion.

But sure, if it's easier, we can have 5.8.0 in the README. What's five
extra years matter anyway? Hey, while we're at it, lets change Pg to
build on Borland C and require K&R style!

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2016-11-17 02:49:51 Re: [HACKERS] Patch: Implement failover on libpq connect level.
Previous Message Kyotaro HORIGUCHI 2016-11-17 02:31:09 Re: Document how to set up TAP tests for Perl 5.8.8