Re: TAP / recovery-test fs-level backups, psql enhancements etc

On 2 March 2016 at 07:07, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> Craig Ringer wrote:
>
> > diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
> > index 3d11cbb..8c13655 100644
> > --- a/src/test/perl/TestLib.pm
> > +++ b/src/test/perl/TestLib.pm
> > @@ -112,9 +112,11 @@ INIT
> > #
> > sub tempdir
> > {
> > + my ($prefix) = @_;
> > + $prefix = "tmp_test" if (!$prefix);
>
> This should be "unless defined $prefix". Otherwise if you pass the
> string literal "0" as prefix it will be ignored.
>
>
Ha. I thought something was funny with !$prefix when splitting that out of
Kyotaro Horiguchi's patch but couldn't put my finger on what.

Will amend in the next push. I'll keep the committed 006 Retain tempdirs
for failed tests in that series but amend it to show it's committed
upstream.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services