Re: Failed to delete old ReorderBuffer spilled files

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: atorikoshi <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Failed to delete old ReorderBuffer spilled files
Date: 2017-11-22 02:49:54
Message-ID: CAMsr+YG31Je0e3BhiG2eQmWBPPbgG2zbH3o4r-psykOCNNu3ZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 20 November 2017 at 18:35, atorikoshi <torikoshi_atsushi_z2(at)lab(dot)ntt(dot)co(dot)jp
> wrote:

> Hi,
>
> I put many queries into one transaction and made ReorderBuffer spill
> data to disk, and sent SIGKILL to postgres before the end of the
> transaction.
>
> After starting up postgres again, I observed the files spilled to
> data wasn't deleted.

Since this can only happen on crash exits, and the reorderbuffer data is
useless after a decoding backend exits, why don't we just recursively
delete the tree contents on Pg startup?

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2017-11-22 02:53:39 Re: Logical Replication and triggers
Previous Message Kyotaro HORIGUCHI 2017-11-22 02:48:14 Re: Failed to delete old ReorderBuffer spilled files