| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | sanyam jain <sanyamjain22(at)live(dot)in> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com>, Thom Brown <thom(at)linux(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logical decoding on standby |
| Date: | 2017-06-27 05:22:49 |
| Message-ID: | CAMsr+YFTfrNomTW+vLVf6dP8Y92c4cspPcehO7OFViLtgNJ3Ew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21 June 2017 at 13:28, sanyam jain <sanyamjain22(at)live(dot)in> wrote:
> Hi,
>
> In this patch in walsender.c sendTimeLineIsHistoric is set to true when
> current and ThisTimeLineID are equal.
>
> sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID;
>
>
> Shouldn't sendTimeLineIsHistoric is true when state->currTLI is less than
> ThisTimeLineID.
Correct, that was a bug. I thought it got fixed upthread though.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-06-27 05:24:09 | Re: Logical decoding on standby |
| Previous Message | Thomas Munro | 2017-06-27 05:21:50 | Out of date comment in predicate.c |