| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Transaction traceability - txid_status(bigint) |
| Date: | 2016-09-02 13:01:58 |
| Message-ID: | CAMsr+YEhUFP4Lv+5xOGK6LPAToARb=f4O=NuuZeTzYX08vkTHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2 September 2016 at 20:38, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 2 Sep. 2016 8:30 pm, "Simon Riggs" <simon(at)2ndquadrant(dot)com> wrote:
>>
>> On 2 September 2016 at 13:16, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>>
>> > So I've moved it to xlog.c...
>>
>> I'm pretty sure it shouldn't live in xlog.c, but there may be some
>> good reason I can't see yet.
>
> Ugh. Yes. transam.c would be rather saner.
>
> Only for the helper to determine if an xid is recent though; txid_ status
> stays in adt/xact.c where it belongs along with txid_current() etc.
Fixed, moved to transam.c.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Introduce-txid_status-bigint-to-get-status-of-an-xac.patch | text/x-patch | 17.3 KB |
| 0002-Add-txid_convert_if_recent-to-get-the-32-bit-xid-fro.patch | text/x-patch | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-09-02 13:23:46 | Re: Password identifiers, protocol aging and SCRAM protocol |
| Previous Message | Tom Lane | 2016-09-02 12:55:13 | Tracking timezone abbreviation removals in the IANA tz database |