From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Regina Obe <lr(at)pcorp(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PostgreSQL Version 10, missing minor version |
Date: | 2016-08-29 08:56:57 |
Message-ID: | CAMsr+YEdH90NrO5mc1VaZXKbPdd28FFSrqYWty9HcgBMvrLHyA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 29 August 2016 at 11:46, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-08-29 11:41:00 +0800, Craig Ringer wrote:
>> On 29 August 2016 at 02:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> > "Regina Obe" <lr(at)pcorp(dot)us> writes:
>> >> The routine in PostGIS to parse out the version number from pg_config is
>> >> breaking in the 10 cycle
>> >
>> > TBH, I wonder why you are doing that in the first place; it does not
>> > seem like the most reliable source of version information. If you
>> > need to do compile-time tests, PG_CATALOG_VERSION is considered the
>> > best thing to look at, or VERSION_NUM in Makefiles.
>>
>> This is my cue to pop up and say that if you're looking at the startup
>> message you have to use the version string, despite it not being the
>> most reliable source of information, because we don't send
>> server_version_num ;)
>>
>> Patch attached. Yes, I know PostGIS doesn't use it, but it makes no
>> sense to tell people not to parse the server version out in some
>> situations then force them to in others.
>
> If they're using pg_config atm, that seems unlikely to be related. That
> sounds more like a build time issue - there won't be a running server.
Yeah, you're right, and I shouldn't hijack an unrelated thread. Please
disregard, will follow up separately.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2016-08-29 09:35:18 | Re: GIN logging GIN_SEGMENT_UNMODIFIED actions? |
Previous Message | Craig Ringer | 2016-08-29 08:28:07 | Re: Renaming of pg_xlog and pg_clog |