From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Allow cluster_name in log_line_prefix |
Date: | 2019-10-28 04:33:00 |
Message-ID: | CAMsr+YE-Q5ftx9+6xxfrY6j_xXCL1QQ5DqBBtknyRoVOrNpiJg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi folks
I was recently surprised to notice that log_line_prefix doesn't support a
cluster_name placeholder. I suggest adding one. If I don't hear objections
I'll send a patch.
Before anyone asks "but why?!":
* A constant (short) string in log_line_prefix is immensely useful when
working with logs from multi-node systems. Whether that's physical
streaming replication, logical replication, Citus, whatever, it doesn't
matter. It's worth paying the small storage price for sanity when looking
at logs.
* Yes you can embed it directly into log_line_prefix. But then it gets
copied by pg_basebackup or whatever you're using to clone standbys etc, so
you can easily land up with multiple instances reporting the same name.
This rather defeats the purpose.
--
Craig Ringer http://www.2ndQuadrant.com/
2ndQuadrant - PostgreSQL Solutions for the Enterprise
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2019-10-28 04:39:39 | Re: Restore replication settings when modifying a field type |
Previous Message | Smith, Peter | 2019-10-28 03:42:02 | RE: Proposal: Add more compile-time asserts to expose inconsistencies. |