Re: max_slot_wal_keep_size comment in postgresql.conf

From: Isaac Morland <isaac(dot)morland(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: max_slot_wal_keep_size comment in postgresql.conf
Date: 2020-05-27 02:56:39
Message-ID: CAMsGm5c5Fq4ERA0nimoujG_GVgp-Wj1Ne_QDa3X9SafdQK1ZVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 26 May 2020 at 21:46, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:

> At Tue, 26 May 2020 09:10:40 -0400, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
> wrote in
> > In postgresql.conf, it says:
> >
> > #max_slot_wal_keep_size = -1 # measured in bytes; -1 disables
> >
> > I don't know if that is describing the dimension of this parameter or the
> > units of it, but the default units for it are megabytes, not individual
> > bytes, so I think it is pretty confusing.
>
> Agreed. It should be a leftover at the time the unit was changed
> (before committed) to MB from bytes. The default value makes the
> confusion worse.
>
> Is the following works?
>
> #max_slot_wal_keep_size = -1 # in MB; -1 disables

Extreme pedant question: Is it MB (10^6 bytes) or MiB (2^20 bytes)?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiro Ikeda 2020-05-27 04:14:51 Re: Why don't you to document pg_shmem_allocations view's name list?
Previous Message Tom Lane 2020-05-27 01:49:16 Re: some grammar refactoring