Re: BUG #17973: Reinit of pgstats entry for dropped DB can break autovacuum daemon

Thanks for the quick patch Andres! Jacob tested and that appears to
fix our scenario.

On Wed, Jun 14, 2023 at 3:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2023-06-14 14:57:44 -0700, Andres Freund wrote:
> > If I am not, then we we should defer setting MyDatabaseId until after "Recheck
> > pg_database", e.g. by setting 'dboid' for the in_dbname path.
> >
> > I think that would likely end up with *less* code than before, because we'd
> > need less redundant code.
> >
> >
> > It's a bit odd that we do the second lookup with dbname, rather the oid we
> > previously looked up.
> >
> >
> > Afaics there's no reason to look up MyDatabaseTableSpace before the recheck.
>
> Attached is a rough prototype implementing this idea. Could you check if that
> fixes the issue?
>
> Greetings,
>
> Andres Freund