From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: when the startup process doesn't (logging startup delays) |
Date: | 2021-06-21 06:36:30 |
Message-ID: | CAMm1aWadG_xgncYxFt-GAqRXWL2WE-5bu3qdJtW6CYEwhw7QbQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> What is DUMMY about ? If you just want to separate the "start" from "end",
> you could write:
>
> /* codes for start of operations */
> FSYNC_IN_PROGRESS
> SYNCFS_IN_PROGRESS
> ...
> /* codes for end of operations */
> FSYNC_END
> SYNCFS_END
> ...
That was by mistake and I have corrected it in the attached patch.
Thanks & Regards,
Nitin Jadhav
On Thu, Jun 17, 2021 at 6:22 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> + * Codes of the operations performed during startup process
> + */
> +typedef enum StartupProcessOp
> +{
> + SYNCFS_IN_PROGRESS,
> + FSYNC_IN_PROGRESS,
> + RECOVERY_IN_PROGRESS,
> + RESET_UNLOGGED_REL_IN_PROGRESS,
> + DUMMY,
> + SYNCFS_END,
> + FSYNC_END,
> + RECOVERY_END,
> + RESET_UNLOGGED_REL_END
> +} StartupProcessOp;
>
> What is DUMMY about ? If you just want to separate the "start" from "end",
> you could write:
>
> /* codes for start of operations */
> FSYNC_IN_PROGRESS
> SYNCFS_IN_PROGRESS
> ...
> /* codes for end of operations */
> FSYNC_END
> SYNCFS_END
> ...
>
> Or group them together like:
>
> FSYNC_IN_PROGRESS,
> FSYNC_END,
> SYNCFS_IN_PROGRESS,
> SYNCFS_END,
> RECOVERY_IN_PROGRESS,
> RECOVERY_END,
> RESET_UNLOGGED_REL_IN_PROGRESS,
> RESET_UNLOGGED_REL_END,
>
> --
> Justin
Attachment | Content-Type | Size |
---|---|---|
v4-0001-startup-process-progress.patch | application/octet-stream | 13.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2021-06-21 06:37:35 | Re: [HACKERS] logical decoding of two-phase transactions |
Previous Message | Amit Kapila | 2021-06-21 05:49:58 | Re: Optionally automatically disable logical replication subscriptions on error |