| From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve GetConfigOptionValues function |
| Date: | 2023-01-18 07:53:30 |
| Message-ID: | CAMm1aWZY38naak+RiG9XvOGEVa+NJ=Y0YYHnzEHdSSVDh0OfHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attaching the patch.
On Wed, Jan 18, 2023 at 1:21 PM Nitin Jadhav
<nitinjadhavpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> GetConfigOptionValues function extracts the config parameters for the
> given variable irrespective of whether it results in noshow or not.
> But the parent function show_all_settings ignores the values parameter
> if it results in noshow. It's unnecessary to fetch all the values
> during noshow. So a return statement in GetConfigOptionValues() when
> noshow is set to true is needed. Attached the patch for the same.
> Please share your thoughts.
>
> Thanks & Regards,
> Nitin Jadhav
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Improve-GetConfigOptionValues-function.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-01-18 07:54:43 | Re: Helper functions for wait_for_catchup() in Cluster.pm |
| Previous Message | Nitin Jadhav | 2023-01-18 07:51:05 | Improve GetConfigOptionValues function |