Re: vac truncation scan problems

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: vac truncation scan problems
Date: 2015-03-31 17:18:12
Message-ID: CAMkU=1zss-1_pbcUZ1oMgTkF_rsi1t4Z+nYKf3CCHStzfvyvEg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 31, 2015 at 1:28 AM, Kyotaro HORIGUCHI <
horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:

> Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .
>
> It allows vucuum freeze to be skipped and inversely lets regular
> vacuum wait for lock. The attched patch fixes it.
>
>
> In table_recheck_autovac, vacuum options are determined as following,
>
> > tab->at_vacoptions = VACOPT_SKIPTOAST |
> > (dovacuum ? VACOPT_VACUUM : 0) |
> > (doanalyze ? VACOPT_ANALYZE : 0) |
> !> (wraparound ? VACOPT_NOWAIT : 0);
>
> The line prefixed by '!' looks inverted.
>

Thanks, it is obvious once you see it!

Your patch solved the problem for me.

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2015-03-31 17:26:24 Re: vac truncation scan problems
Previous Message Robert Haas 2015-03-31 17:17:03 Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );