Re: Autovac cancellation is broken in v14

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>
Subject: Re: Autovac cancellation is broken in v14
Date: 2020-08-27 20:20:30
Message-ID: CAMkU=1zB0hqN8NChuvT00tMvxHEx=_-WZU4x6OO77kkFzD2ccA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 27, 2020 at 3:10 PM Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:

> If I create a large table with "CREATE TABLE ... AS SELECT ... from
> generate_series(1,3e7)" with no explicit transactions, then once it is done
> I wait for autovac to kick in, then when I try to build an index on that
> table (or drop the table) the autovac doesn't go away on its own.
>

After a bit more poking at this, I think we are checking if we ourselves
are an autovac process, not doing the intended check of whether the other
guy is one.

Where would be a good spot to add a regression test for this?
"isolation_regression" ?
Cheers,

Jeff

Attachment Content-Type Size
fix_autovac_cancel.patch application/octet-stream 595 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-08-27 20:28:54 Re: [EXTERNAL] Re: WIP: WAL prefetch (another approach)
Previous Message Robert Haas 2020-08-27 20:19:23 Re: [EXTERNAL] Re: WIP: WAL prefetch (another approach)