| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SET work_mem = '1TB'; |
| Date: | 2013-06-18 04:06:08 |
| Message-ID: | CAMkU=1yQymPj_=2HA_qwiOhf40fGFGehBQXq_8+yxdHrgQCzWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, May 21, 2013, Simon Riggs wrote:
> I worked up a small patch to support Terabyte setting for memory.
> Which is OK, but it only works for 1TB, not for 2TB or above.
>
I've incorporated my review into a new version, attached.
Added "TB" to the docs, added the macro KB_PER_TB, and made "show" to print
"1TB" rather than "1024GB".
I tested several of the memory settings to see that it can be set and
retrieved. I haven't tested actual execution as I don't have that kind of
RAM.
I don't see how it could have a performance impact, it passes make check
etc., and I don't think it warrants a new regression test.
I'll set it to ready for committer.
Cheers,
Jeff
| Attachment | Content-Type | Size |
|---|---|---|
| terabyte_work_mem.JJ.v2.patch | text/x-patch | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Link | 2013-06-18 04:42:37 | Patch for fast gin cache performance improvement |
| Previous Message | Jeff Janes | 2013-06-18 02:55:44 | spurious wrap-around shutdown |