Re: add verbosity to pg_basebackup for sync

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add verbosity to pg_basebackup for sync
Date: 2018-07-29 14:45:10
Message-ID: CAMkU=1yG4Kyf3YJm55r5JecXt7wg+6oste38CkgmHbU6XDTnkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 27, 2018 at 7:10 PM, Michael Paquier <michael(at)paquier(dot)xyz>
wrote:

> On Fri, Jul 27, 2018 at 11:58:42AM -0400, Jeff Janes wrote:
> > But it was really waiting for the syncs of the new -D dir to finish. The
> > attached patch adds a -v notice that it is starting to do the sync, with
> > the wording taken from initdb's equivalent message.
>
> This is a good idea. Would we want that back-patched? I am sure that
> nobody is going to complain for an extra informational log.
>

Thanks for committing it. It is probably safer not to backpatch, as
someone might have scripts that look at the output of -v so it shouldn't
change between minor releases. I don't think looking at those would be a
good idea, but they may have their reasons.

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-29 14:53:46 Re: Inconsistent error message in bt_page_items_bytea().
Previous Message Jeff Janes 2018-07-29 14:31:47 Re: [PATCH] Improve geometric types