Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay
Date: 2019-09-26 23:57:51
Message-ID: CAMkU=1xd2w6OmgHb_fCQW3-gHOswAEThqgkbZ=WLU_qbcok4Lg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

>
> Reading over this code, I noticed that the detection of the catch-up
> state ends up being duplicate code, so I would rework that function as
> in the attached patch.
>
> The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
> I'm not going to change that in a backpatchable bug fix.
>

Hi Alvaro, does this count as a review? And Craig, do you agree with
Alvaro's patch as a replacement for your own?

Thanks,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-09-27 00:32:38 Re: range test for hash index?
Previous Message Tomas Vondra 2019-09-26 23:00:36 Re: Optimize partial TOAST decompression