From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: segfault in hot standby for hash indexes |
Date: | 2017-03-27 15:56:55 |
Message-ID: | CAMkU=1xX-q-PzL=v6mfGoKq2Fya=FqdMW48+_fTEzcArqET_Ww@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 24, 2017 at 12:49 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> On Fri, Mar 24, 2017 at 12:25 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
> wrote:
> >>
> >> I think it would have been probably okay to use *int* for ntuples as
> >> that matches with what you are actually assigning in the function.
> >
> > okay, corrected it. Attached is newer version of patch.
> >
>
> Thanks, this version looks good to me.
>
It solves the problem for me. I'd like to test that I get the right answer
on the standby, not just the absence of a crash, but I don't know how to do
that effectively. Has anyone used the new wal replay block consistency
tool on hash indexes since this microvacuum code was committed?
Jeff
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-03-27 15:57:35 | Re: crashes due to setting max_parallel_workers=0 |
Previous Message | Tom Lane | 2017-03-27 15:52:05 | Re: WIP: Faster Expression Processing v4 |