Re: Allowing line-continuation in pgbench custom scripts

On Monday, May 26, 2014, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Amit Langote <amitlangote09(at)gmail(dot)com <javascript:;>> writes:
> > In a custom pgbench script, it seems convenient to be able to split a
> > really long query to span multiple lines using an escape character
> > (bash-style). Attached adds that capability to read_line_from_file()
> > in pgbench.c
>
> This seems pretty likely to break existing scripts that happen to contain
> backslashes. Is it really worth the compatibility risk?
>

Do you mean due to the bugs you point out, or in general? Is it really at
all likely that someone has ended a line of their custom benchmark file
with a backslash? I'm having a hard time seeing what, other than malice,
would prod someone to do that.

Cheers,

Jeff