| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Thom Brown <thom(at)linux(dot)com>, "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Subject: | Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs) |
| Date: | 2016-02-10 06:31:13 |
| Message-ID: | CAMkU=1w1xOSwnVxpJ4msfiXBkc84CJweV7TbfHZ+63TViRXAvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 9, 2016 at 11:16 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Feb 9, 2016 at 8:39 AM, Ashutosh Bapat
> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>> Thanks Jeevan for your review and comments. PFA the patch which fixes those.
>
> Committed with a couple more small adjustments.
I'm getting a compiler warning which I think is coming from this commit.
postgres_fdw.c: In function 'fetch_more_data':
postgres_fdw.c:2526:17: warning: unused variable 'fsplan' [-Wunused-variable]
ForeignScan *fsplan = (ForeignScan *) node->ss.ps.plan;
Thanks,
Jeff
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-02-10 06:32:50 | Re: [PATCH] Refactoring of LWLock tranches |
| Previous Message | Kouhei Kaigai | 2016-02-10 06:25:01 | Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c) |