Re: Fix for issue RM1336 [pgadmin4]

From: Adam Brusselback <adambrusselback(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fix for issue RM1336 [pgadmin4]
Date: 2016-06-20 13:29:40
Message-ID: CAMjNa7e3vkEsiRGqt6kw3Z+z6v-z6Ox4-F0VmCDJEGW2pynWOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I'm just wondering what the thought process is for making the shortcuts
configurable, or why that's going to be significantly hard? I find that to
be highly desirable feature, one of the reasons being avoiding something
like this from happening (with browser bindings). Some of us have other
tools which are also unconfigurable and bind to the same keys, and now you
have conflicts between them.

However, what I think doesn't matter at all in the scheme of things, I'm
just throwing in my $0.02.

Thanks,
-Adam
On Jun 20, 2016 8:06 AM, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:

> OK, applied as-is for now. I guess all our shortcuts will probably end
> up being Ctrl+Shift+Something :-(
>
> On Mon, Jun 20, 2016 at 10:45 AM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > I tried to find unique shortcuts keys combination using function keys on
> > different platforms (windows, mac, linux ) but no success. Any
> combination
> > of function keys with either of (or some of them together) Alt, Ctrl,
> Shift
> > conflict with either browser functionality or with window functionality
> > (like resize, move, minimize, maximize etc).
> >
> > And regarding Ctrl+F5, it is for hard refresh on some browsers.
> >
> > --
> > Harshal Dhumal
> > Software Engineer
> >
> > EnterpriseDB India: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Thu, Jun 16, 2016 at 8:03 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> On Thu, Jun 16, 2016 at 3:28 PM, Ashesh Vashi
> >> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> > On Thu, Jun 16, 2016 at 5:10 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >> >>
> >> >> On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
> >> >> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> >> >> > Hi,
> >> >> >
> >> >> > As per my offline discussion with Ashesh; He is suggesting not to
> use
> >> >> > Function keys as shortcuts.
> >> >>
> >> >> Why? That is primarily what they are on the keyboard for.
> >> >
> >> > F5 is always bind to refresh function of the browser on linux &
> windows.
> >> > Similarly - many shortcuts of browser are bound to the function keys.
> >> >
> >> > Hence - I asked not to use F5.
> >>
> >> I suggested Ctrl+F5.
> >
> >
> >
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-20 13:33:15 Re: Fix for issue RM1336 [pgadmin4]
Previous Message Dave Page 2016-06-20 13:17:21 Re: [pgAdmin4][Patch]: Remove Query tool from object menu