From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dave(dot)page(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Materialized View Patch File |
Date: | 2013-06-03 06:56:37 |
Message-ID: | CAMcbDBHhk-F3i8OSU8Dg3J36uTogmj7UDs0vcf_n6Qpgn2Kw_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Thanks for update.
Yes it is a bug, I have not put the version check.
Below are the changes.
--- Put the PG version check for mat views
--- In SQL Pane window change the the description of the view from --
MATERIALIZED
View: xxx TO
-- Materialized View: xxx
Please find the updated patch in attachement.
Thanks,
Neel Patel
On Fri, May 31, 2013 at 5:59 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>wrote:
> On Wed, May 29, 2013 at 10:40 AM, Neel Patel
> <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > Please find the updated patch after fixing some of the issues and
> comments
> > given by Ashesh.
>
> I haven't looked at the code, but judging by the error I got when
> first clicking on a view on a PG 9.2 server, you forgot to make this
> code version-dependent:
>
> 2013-05-31 13:25:57 QUERY : Scalar query (localhost:5432): SELECT
> count(*) FROM pg_matviews WHERE matviewname = 'pem.avail_servers' AND
> schemaname = 'pem'
> 2013-05-31 13:25:57 ERROR : ERROR: relation "pg_matviews" does not exist
> LINE 1: SELECT count(*) FROM pg_matviews WHERE matviewname = 'pem.av...
> ^
> It then goes on to give the view definition as:
>
> -- MATERIALIZED View: pem.avail_servers
>
> -- DROP MATERIALIZED VIEW pem.avail_servers;
>
> CREATE MATERIALIZED VIEW pem.avail_servers AS
> SELECT s.id, s.description, s.server, s.port, s.database, s.ssl,
> s.serviceid,
> ...
> ...
>
> (as a side note, the first line for a real mat view should be: "--
> Materialized View: pem.avail_servers")
>
> --
> Dave Page
> Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
Attachment | Content-Type | Size |
---|---|---|
MaterializedView_V3.patch | application/octet-stream | 76.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2013-06-03 11:50:59 | Re: Materialized View Patch File |
Previous Message | Dave Page | 2013-05-31 12:29:48 | Re: Materialized View Patch File |