Re: Materialized View Patch File

Hi Dave,

Please find the updated patch file for Materialized View with below changes.

---- Materialized View UI changes
---- Added Option for WITH DATA
---- Some of the bug fixes

Thanks,
Neel Patel

On Mon, Jun 10, 2013 at 5:08 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>wrote:

> Hi
>
> Per our discussion earlier, please put the Materialized: Yes/No option
> at the top of the Materialization tab, and below that add a tabset
> with three tabs for Options, and the heap and toast Vacuum options.
>
> Thanks.
>
> On Mon, Jun 10, 2013 at 10:16 AM, Neel Patel
> <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > We have below three options.
> >
> > 1. Materialized Yes/No
> > 2. TableSpace
> > 3. Fill Factor
> >
> > I have checked with three options and below that two tabs so for that we
> > need to increase little height of the dialog to fit in. If so then we
> will
> > implement that and after detail testing will send you the patch along
> with
> > all the fixes.
> >
> > Thanks,
> > Neel Patel
> >
> >
> > On Mon, Jun 10, 2013 at 12:27 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
> > wrote:
> >>
> >> Hi
> >>
> >> On Mon, Jun 10, 2013 at 7:23 AM, Neel Patel <
> neel(dot)patel(at)enterprisedb(dot)com>
> >> wrote:
> >> > Hi Dave,
> >> >
> >> > We can combine the Materialization Tab and auto-vacuum tab.
> >> >
> >> > To make it consistent with other UI I would suggest to have one Tab
> >> > called
> >> > "Materialization" and in that tab we have another three Tabs.
> >> >
> >> > 1. Options ( Or we can have another name ) ---- For setting the option
> >> > for
> >> > materialized view
> >> > 2. Table
> >> > 3. Toast Table
> >>
> >> There are only two options aren't there (Materialised: Yes/no and fill
> >> factor)? If so, I'd have one tab with those options at the top, then a
> >> "Vacuum Options" panel below that with 2 tabs for the vacuum stuff. I
> >> think that'll fit just fine.
> >>
> >>
> >> > On Wed, Jun 5, 2013 at 1:20 PM, Neel Patel <
> neel(dot)patel(at)enterprisedb(dot)com>
> >> > wrote:
> >> >>
> >> >> Hi Dave,
> >> >>
> >> >> Please find the patch in attachement with below changes.
> >> >>
> >> >> --- Changed the UI design and make it consistence with dlgTable.
> >> >>
> >> >> When user creates the view then user has option to create Normal View
> >> >> Or
> >> >> Materialized View.
> >> >> User is not allowed to change the "Security Barrier" and
> "Materialized
> >> >> View" at the same time because "Security Barrier" option is for
> Normal
> >> >> View.
> >> >>
> >> >> So we put the below message
> >> >>
> >> >> "Security barrier and materialized view can not be enbale at the same
> >> >> time"
> >> >>
> >> >> Let me know if any modification is required.
> >> >>
> >> >> Thanks,
> >> >> Neel Patel
> >> >>
> >> >>
> >> >> On Tue, Jun 4, 2013 at 12:02 AM, Dave Page <
> dave(dot)page(at)enterprisedb(dot)com>
> >> >> wrote:
> >> >>>
> >> >>> On Mon, Jun 3, 2013 at 7:29 PM, Neel Patel
> >> >>> <neel(dot)patel(at)enterprisedb(dot)com>
> >> >>> wrote:
> >> >>> >
> >> >>> >
> >> >>> > On Mon, Jun 3, 2013 at 5:20 PM, Dave Page
> >> >>> > <dave(dot)page(at)enterprisedb(dot)com>
> >> >>> > wrote:
> >> >>> >>
> >> >>> >> Hi
> >> >>> >>
> >> >>> >> On Mon, Jun 3, 2013 at 7:56 AM, Neel Patel
> >> >>> >> <neel(dot)patel(at)enterprisedb(dot)com>
> >> >>> >> wrote:
> >> >>> >> > Hi Dave,
> >> >>> >> >
> >> >>> >> > Thanks for update.
> >> >>> >> >
> >> >>> >> > Yes it is a bug, I have not put the version check.
> >> >>> >> >
> >> >>> >> > Below are the changes.
> >> >>> >> > --- Put the PG version check for mat views
> >> >>> >> > --- In SQL Pane window change the the description of the view
> >> >>> >> > from
> >> >>> >> > --
> >> >>> >> > MATERIALIZED View: xxx TO
> >> >>> >> > -- Materialized View: xxx
> >> >>> >> >
> >> >>> >> > Please find the updated patch in attachement.
> >> >>> >>
> >> >>> >> Thanks - a few more comments now I've tested further:
> >> >>> >>
> >> >>> >> - The tab should be called "Materialization" (unless someone has
> a
> >> >>> >> better
> >> >>> >> idea)
> >> >>> >>
> >> >>> > I will fix it.
> >> >>> >
> >> >>> >>
> >> >>> >> - I can still enable the "Materialized View" option on a 9.2
> >> >>> >> database
> >> >>> >> on the dialogue.
> >> >>> >>
> >> >>> >
> >> >>> > I will fix it.
> >> >>> >
> >> >>> >>
> >> >>> >> - I can't select a tablespace from the drop down menu, but I can
> >> >>> >> type
> >> >>> >> a name in. Should be select-only - see dlgTable.
> >> >>> >
> >> >>> >
> >> >>> > I will fix it.
> >> >>> >
> >> >>> >>
> >> >>> >>
> >> >>> >> - The vacuum options UI design should match the existing one on
> >> >>> >> dlgTable (it's a nice design, but consistency comes first).
> >> >>> >
> >> >>> >
> >> >>> > Can we change dlgTable with new UI design ?
> >> >>>
> >> >>> Not for this release, it's too late.
> >> >>>
> >> >>>
> >> >>> --
> >> >>> Dave Page
> >> >>> Chief Architect, Tools & Installers
> >> >>> EnterpriseDB: http://www.enterprisedb.com
> >> >>> The Enterprise PostgreSQL Company
> >> >>>
> >> >>> Blog: http://pgsnake.blogspot.com
> >> >>> Twitter: @pgsnake
> >> >>
> >> >>
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Chief Architect, Tools & Installers
> >> EnterpriseDB: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >
> >
>
>
>
> --
> Dave Page
> Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>