Re:

Hi Dave,

Please find the patch for 1.16 branch.

Thanks,
Neel Patel

On Wed, May 22, 2013 at 5:27 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Probably because of the sshtunnel changes in the master.
> You should have done it in reverse. :P
>
>
> On Wed, May 22, 2013 at 5:25 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>wrote:
>
>> Hmm, I couldn't cherry pick it to 1.16, and don't have time to work on
>> that now. Can you provide a patch for that branch too please?
>>
>> Thanks.
>>
>> On Wed, May 22, 2013 at 11:51 AM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>> wrote:
>> > Thanks, patch applied.
>> >
>> > On Wed, May 22, 2013 at 11:26 AM, Neel Patel
>> > <neel(dot)patel(at)enterprisedb(dot)com> wrote:
>> >> Hi Dave,
>> >>
>> >> Sorry forgot to add the flag wxFLP_USE_TEXTCTRL at two places in
>> >> dlgServer.xrc file . so attached updated patch file.
>> >>
>> >>
>> >> Thanks,
>> >> Neel Patel
>> >>
>> >>
>> >> On Wed, May 22, 2013 at 4:35 PM, Neel Patel <
>> neel(dot)patel(at)enterprisedb(dot)com>
>> >> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> Rohit found one crash while we add the servers in the PEM.
>> >>>
>> >>> With the help of Ashesh we debug the code and found that crash is due
>> to
>> >>> below changes of SSL certificate authentication.
>> >>>
>> >>>
>> >>> commit 5a7d5b32128c950e232d8239a35dcbd08b36a237
>> >>> Author: Dave Page <dpage(at)pgadmin(dot)org>
>> >>> Date: Fri May 17 10:11:54 2013 +0100
>> >>>
>> >>> Fix SSL certificate authentication.
>> >>>
>> >>>
>> >>> Analysis:
>> >>>
>> >>> We found the crash in the function CreateObject(pgCollection
>> *collection)
>> >>> in dlg/dlgServer.cpp at below line.
>> >>>
>> >>> obj->SetSSLCert(pickerSSLCert->GetTextCtrlValue());
>> >>>
>> >>>
>> >>> At above line returns a pointer to the text control handle by window
>> and
>> >>> we have not set the wxFLP_USE_TEXTCTRL flag. so when we create the
>> file
>> >>> picker object and if we not specified the wxFLP_USE_TEXTCTRL flag
>> then it
>> >>> return NULL pointer of text control.
>> >>>
>> >>> So we have set the flag wxFLP_USE_TEXTCTRL in the ui file
>> dlgServer.ui to
>> >>> fix the issue.
>> >>>
>> >>> Please find the patch in attachement.
>> >>>
>> >>> Thanks,
>> >>> Neel Patel
>> >>>
>> >>>
>> >>> --
>> >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
>> )
>> >>> To make changes to your subscription:
>> >>> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>>
>> >>
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Chief Architect, Tools & Installers
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>>
>>
>>
>> --
>> Dave Page
>> Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>
>
>
> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>