From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dave(dot)page(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: |
Date: | 2013-05-22 11:26:53 |
Message-ID: | CAMcbDBF8Q5-j2qQ0bmxAuxAJLGckyO2H_nPxODGPQxLfDmuPeA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Sorry forgot to add the flag wxFLP_USE_TEXTCTRL at two places in
dlgServer.xrc file . so attached updated patch file.
Thanks,
Neel Patel
On Wed, May 22, 2013 at 4:35 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>wrote:
> Hi Dave,
>
> Rohit found one crash while we add the servers in the PEM.
>
> With the help of Ashesh we debug the code and found that crash is due to
> below changes of SSL certificate authentication.
>
>
> commit 5a7d5b32128c950e232d8239a35dcbd08b36a237
> Author: Dave Page <dpage(at)pgadmin(dot)org>
> Date: Fri May 17 10:11:54 2013 +0100
>
> Fix SSL certificate authentication.
>
>
> *Analysis:*
>
> We found the crash in the function CreateObject(pgCollection *collection)
> in dlg/dlgServer.cpp at below line.
>
> obj->SetSSLCert(pickerSSLCert->GetTextCtrlValue());
>
>
> At above line returns a pointer to the text control handle by window and
> we have not set the wxFLP_USE_TEXTCTRL flag. so when we create the file
> picker object and if we not specified the wxFLP_USE_TEXTCTRL flag then it
> return NULL pointer of text control.
>
> So we have set the flag wxFLP_USE_TEXTCTRL in the ui file dlgServer.ui to
> fix the issue.
>
> Please find the patch in attachement.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
Attachment | Content-Type | Size |
---|---|---|
FilePickerCtrl_SSL_Cert.patch | application/octet-stream | 2.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2013-05-22 11:51:46 | pgAdmin III commit: Use a textbox with file pickers. |
Previous Message | Neel Patel | 2013-05-22 11:05:38 |