Simplify create_merge_append_path a bit for clarity

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Simplify create_merge_append_path a bit for clarity
Date: 2023-08-11 02:31:34
Message-ID: CAMbWs4_n1bgH2nACMuGsXZct3KH6PBFS0tPdQsXdstRfyxTunQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As explained in the comments for generate_orderedappend_paths, we don't
currently support parameterized MergeAppend paths, and it doesn't seem
like going to change anytime soon. Based on that, we could simplify
create_merge_append_path a bit, such as set param_info to NULL directly
rather than call get_appendrel_parampathinfo() for it. We already have
an Assert on that in create_merge_append_plan.

I understand that the change would not make any difference for
performance, it's just for clarity's sake.

Thanks
Richard

Attachment Content-Type Size
v1-0001-Simplify-create_merge_append_path-a-bit-for-clarity.patch application/octet-stream 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-08-11 02:43:28 Re: [PATCH] Add loongarch native checksum implementation.
Previous Message Donghang Lin 2023-08-11 02:07:02 Re: 2023-08-10 release announcement draft