| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18422: Assert in expandTupleDesc() fails on row mismatch with additional SRF |
| Date: | 2024-04-10 07:58:51 |
| Message-ID: | CAMbWs4_j1wq+nUK4t1oROOj2Qgvds=3G4RWA3NBNygf1wkha0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Apr 10, 2024 at 11:32 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > I wonder why the v2 patch does not apply this same rule in
> > process_function_rte_ref(), by checking if the 'rtfunc' has a coldeflist
> > before it calls get_expr_result_tupdesc.
>
> I guess we could. It won't matter because the following code will
> reject RECORD in any case; but we could save a few cycles by not
> calling get_expr_result_tupdesc there.
Indeed. I think it would be better to add this same rule to
process_function_rte_ref(), or at least write some comments there to
explain why it is not necessary to check rtfunc->funccolnames while
other places do.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2024-04-10 10:06:40 | BUG #18425: KB5036892 Microsoft Update Package Issue |
| Previous Message | Tom Lane | 2024-04-10 03:32:17 | Re: BUG #18422: Assert in expandTupleDesc() fails on row mismatch with additional SRF |