Re: Fix shadow warnings in logical replication code

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix shadow warnings in logical replication code
Date: 2023-08-30 01:50:17
Message-ID: CAMbWs4_XsNoa4DAX0-J0eGkpkrjDS1Wy=WU57EKS1OGDorG3ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 30, 2023 at 8:49 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> There is much more going on with -Wshadow, but let's do things
> incrementally, case by case.

Yeah, IIRC the source tree currently is able to be built without any
shadow-related warnings with -Wshadow=compatible-local. But with
-Wshadow or -Wshadow=local, you can still see a lot of warnings.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2023-08-30 01:55:56 Re: pgbench: allow to exit immediately when any client is aborted
Previous Message Nathan Bossart 2023-08-30 01:35:06 Re: Wrong usage of pqMsg_Close message code?