| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: foreign join error "variable not found in subplan target list" |
| Date: | 2022-08-30 02:21:43 |
| Message-ID: | CAMbWs4_8ACt0b8Z8PTkSg9RbE1_OTsbA25k0OFp+faxBT9tuuQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Aug 30, 2022 at 10:04 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > To be concrete, I mean something like this:
>
> > + /* Update the cost and width fields if we have added any
> > new columns. */
> > + if (!equal(epq_path->pathtarget->exprs, target->exprs))
> > + set_pathtarget_cost_width(root, target);
>
> Wouldn't a list_length() comparison be sufficient? equal() seems
> like overkill.
Yeah, list_length comparison would do, as we only append new columns
here. Thanks for the suggestion!
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-08-30 05:50:26 | Re: pg_rewind WAL segments deletion pitfall |
| Previous Message | Kyotaro Horiguchi | 2022-08-30 02:17:50 | Re: BUG #17601: Problem running the post-install step. Installation may not complete correctly. |