Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents
Date: 2024-04-12 09:11:25
Message-ID: CAMbWs49kAsZUsj7-0SBLvE9+uKz0RCqMEmM3NVytc1YvS8sTrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 12, 2024 at 4:19 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> After further work on the comments, I pushed the result.
>
> Thanks for working on this.

Thanks for pushing!

BTW, I noticed a typo in the comment of add_base_clause_to_rel.

--- a/src/backend/optimizer/plan/initsplan.c
+++ b/src/backend/optimizer/plan/initsplan.c
@@ -2644,7 +2644,7 @@ add_base_clause_to_rel(PlannerInfo *root, Index relid,
* apply_child_basequals() sees, whereas the inh==false one is what's
used
* for the scan node in the final plan.
*
- * We make an exception to this is for partitioned tables. For these,
we
+ * We make an exception to this for partitioned tables. For these, we

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2024-04-12 09:12:46 Re: Add notes to pg_combinebackup docs
Previous Message Magnus Hagander 2024-04-12 09:09:11 Re: Add notes to pg_combinebackup docs