Re: Another incorrect comment for pg_stat_statements

On Wed, Jun 28, 2023 at 3:04 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> > - /* Remove the key if it exists, starting with the
> top-level entry */
> > + /* Remove the key if it exists, starting with the
> non-top-level entry */
> > key.toplevel = false;
> > entry = (pgssEntry *) hash_search(pgss_hash, &key,
> HASH_REMOVE, NULL);
> > if (entry) /* found */
>
> Nice catch. That's indeed wrong. Will fix.

+1. To nitpick, how about we remove the blank line just before removing
the key for top level entry?

- /* Also remove entries for top level statements */
+ /* Also remove entries if exist for top level statements */
key.toplevel = true;
-
- /* Remove the key if exists */
entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);

Thanks
Richard