| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Wrong results with grouping sets |
| Date: | 2024-07-10 01:22:54 |
| Message-ID: | CAMbWs49RNmFhgDzoL=suWJrCSk-wizXa6uVtp0Jmz0z+741nSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 6, 2024 at 9:26 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, Jul 4, 2024 at 6:02 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > I don't have any specific thoughts on backpatching, but I have started
> > reviewing the patches.
> Thanks for reviewing this patchset!
Here is an updated version of this patchset. I've added some comments
according to the review feedback, and also tweaked the commit messages
a bit more.
Additionally, I've made a change to only add the new RTE_GROUP RTE
when there are acceptable GROUP BY expressions. This allows us to
skip all the trouble of doing this for queries without GROUP BY
clauses.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Introduce-an-RTE-for-the-grouping-step.patch | application/octet-stream | 55.5 KB |
| v10-0002-Mark-expressions-nullable-by-grouping-sets.patch | application/octet-stream | 26.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-07-10 01:25:49 | Re: pgsql: Add pg_get_acl() to get the ACL for a database object |
| Previous Message | Richard Guo | 2024-07-10 01:11:59 | Re: Wrong results with grouping sets |