From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Update the comment in nodes.h to cover Cardinality |
Date: | 2023-12-20 00:39:52 |
Message-ID: | CAMbWs49L3Rj=uN0U4iXXL8qYf9-dAsKcjQF_MwNNdtx2rau37Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 19, 2023 at 10:50 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> On 19.12.23 07:23, Richard Guo wrote:
> > By chance I discovered that the comment for the typedefs of "double"s
> > does not cover Cardinality. Should we update that comment accordingly,
> > maybe something like below?
> >
> > - * Typedefs for identifying qualifier selectivities and plan costs as
> such.
> > - * These are just plain "double"s, but declaring a variable as
> Selectivity
> > - * or Cost makes the intent more obvious.
> > + * Typedefs for identifying qualifier selectivities, plan costs and
> > + * estimated rows or other count as such. These are just plain
> "double"s,
> > + * but declaring a variable as Selectivity, Cost or Cardinality makes
> the
> > + * intent more obvious.
>
> Fixed, thanks.
Thanks for the fix!
Thanks
Richard
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2023-12-20 00:45:29 | Re: Use of additional index columns in rows filtering |
Previous Message | Tomas Vondra | 2023-12-20 00:39:27 | Re: Use of additional index columns in rows filtering |