Re: Removed unused param isSlice of function transformAssignmentSubscripts

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removed unused param isSlice of function transformAssignmentSubscripts
Date: 2022-09-13 07:20:01
Message-ID: CAMbWs48zXfcVeyWYHGw87GLQEvKjNqmQafhtsXB_UccXXHipYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:

> Param isSlice was once used to identity targetTypeId for
> transformAssignmentIndirection.
>
> In commit c7aba7c14e, the evaluation was pushed down to
> transformContainerSubscripts.
>
> No need to keep isSlice around transformAssignmentSubscripts.
>
> Attach a patch to remove it.
>

+1. Good catch.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-09-13 07:30:06 Re: Error "initial slot snapshot too large" in create replication slot
Previous Message Kyotaro Horiguchi 2022-09-13 07:15:34 Re: Error "initial slot snapshot too large" in create replication slot