| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix error message for MERGE foreign tables |
| Date: | 2022-10-17 02:07:01 |
| Message-ID: | CAMbWs48dy=uEwKeJHqoyWuHD+NTbrRLp6H7y4zVxf1Cuqd7sMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 14, 2022 at 10:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > Or maybe we can make it even earlier, when we expand an RTE for a
> > partitioned table and add result tables to leaf_result_relids.
>
> I'm not really on board with injecting command-type-specific logic into
> completely unrelated places just so that we can throw an error a bit
> earlier. Alvaro's suggestion of make_modifytable seemed plausible,
> not least because it avoids spending any effort when the command
> couldn't be MERGE at all.
Yeah, that makes sense. Putting this check in inherit.c does look some
weird as there is no other commandType related code in that file.
Agree that Alvaro's suggestion is more reasonable.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-17 02:07:15 | Re: Add regular expression testing for user name mapping in the peer authentication TAP test |
| Previous Message | Peter Smith | 2022-10-17 01:46:59 | Re: create subscription - improved warning message |