Re: Crash in add_paths_to_append_rel

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Crash in add_paths_to_append_rel
Date: 2023-10-10 05:50:15
Message-ID: CAMbWs48ay4k5t3PtDd-sJbrin3hZOakfBfWY36GnkKm3pbHkdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 10, 2023 at 11:52 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > I came across a crash in add_paths_to_append_rel() with the query below.
>
> > It was introduced by commit a8a968a8 where we referenced
> > cheapest_startup_path->param_info without first checking that we have a
> > valid cheapest_startup_path.
>
> I pushed this with just minor adjustments to the comments you wrote. I
> didn't feel the need to reiterate on the set_cheapest() comments.

Thanks for pushing!

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-10 05:57:00 Re: Add const to values and nulls arguments
Previous Message Richard Guo 2023-10-10 05:49:31 Re: Crash in add_paths_to_append_rel