| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Date: | 2023-12-06 07:30:22 |
| Message-ID: | CAMbWs48XTYg0CeEEprK4YQ2=MPAdNepF+5r651kyN5zrs4n5_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've self-reviewed this patch again and I think it's now in a
committable state. I'm wondering if we can mark it as 'Ready for
Committer' now, or we need more review comments/feedbacks.
To recap, this patch postpones reparameterization of paths until
createplan.c, which would help avoid building the reparameterized
expressions we might not use. More importantly, it makes it possible to
modify the expressions in RTEs (e.g. tablesample) and in RelOptInfos
(e.g. baserestrictinfo) for reparameterization. Failing to do that can
lead to executor crashes, wrong results, or planning errors, as we have
already seen.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2023-12-06 08:00:01 | Re: Test 002_pg_upgrade fails with olddump on Windows |
| Previous Message | Michael Paquier | 2023-12-06 07:28:43 | Re: Remove MSVC scripts from the tree |