| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Date: | 2024-01-17 09:50:16 |
| Message-ID: | CAMbWs48UM6-Q0Aovh9Z8R1v2QvnRiJfjyRLMY+fqnVZEQMuW2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 17, 2024 at 5:01 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Tue, Jan 16, 2024 at 2:30 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> On Mon, Jan 8, 2024 at 3:32 AM Richard Guo <guofenglinux(at)gmail(dot)com>
>> wrote:
>
> > Fair point. I think we can back-patch a more minimal fix, as Tom
>> > proposed in [1], which disallows the reparameterization if the path
>> > contains sampling info that references the outer rel. But I think we
>> > need also to disallow the reparameterization of a path if it contains
>> > restriction clauses that reference the outer rel, as such paths have
>> > been found to cause incorrect results, or planning errors as in [2].
>>
>> Do you want to produce a patch for that, to go along with this patch for
>> master?
>
>
> Sure, here it is:
> v10-0001-Avoid-reparameterizing-Paths-when-it-s-not-suitable.patch
>
I forgot to mention that this patch applies on v16 not master.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-01-17 09:50:59 | Re: Add pgindent test to check if codebase is correctly formatted |
| Previous Message | Bertrand Drouvot | 2024-01-17 09:38:45 | Re: Synchronizing slots from primary to standby |