| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Virtual generated columns |
| Date: | 2025-02-24 09:20:51 |
| Message-ID: | CAMbWs4815nLUPbs1y6FmmHCyn0b0E6MGhcB_qLfCEoFUmkCyzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 24, 2025 at 3:50 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> On Sat, Feb 22, 2025 at 11:12 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > On Sat, Feb 22, 2025 at 11:55 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > > Attached are the updated patches to fix all the mentioned issues. I
> > > plan to push them early next week after staring at the code for a bit
> > > longer, barring any objections.
> >
> > Sign... I neglected to make the change in 0001 that a Var newnode
> > compares its varlevelsup with 0 when deciding to wrap it in a
> > ReturningExpr. I made this change in 0002 though, so maybe we're good
> > here. Still, I'll fix this later.
> >
> i also noticed this issue...
>
> some minor comments about v7.
Thanks for reviewing.
Here are the updated patches with revised comments and some tweaks to
the commit messages. I plan to push them in one or two days.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Expand-virtual-generated-columns-in-the-planner.patch | application/octet-stream | 26.2 KB |
| v8-0002-Eliminate-code-duplication-in-replace_rte_variables-callbacks.patch | application/octet-stream | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-02-24 09:21:05 | Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |
| Previous Message | jian he | 2025-02-24 09:17:45 | Re: Non-text mode for pg_dumpall |