Re: BUG #18422: Assert in expandTupleDesc() fails on row mismatch with additional SRF

On Thu, Apr 11, 2024 at 10:13 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > Do you think we can have a parameter in the new get_expr_result_rtfunc()
> > function to indicate whether we want to build an intermediate tupdesc
> > when we have a coldeflist? Then we can set it to true in the two places
> > that are correct already, and set it to false at the places we need to
> > fix. But I'm not sure if including such a new parameter would be an
> > improvement or just make it worse.
>
> I did think about that, but it seems mighty weird. The semantics of
> the flag would have to be something like "I want a tupdesc when the
> result type is COMPOSITE, but not when it's RECORD", which seems
> rather arbitrary.

Indeed.

> Perhaps it'd be sufficient to add a note to the header comment of
> get_expr_result_type warning about when not to use it.

Works for me.

Thanks
Richard