| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, a(dot)kozhemyakin(at)postgrespro(dot)ru, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17570: Unrecognized node type for query with statistics on expressions |
| Date: | 2022-08-05 01:25:08 |
| Message-ID: | CAMbWs4-w6qW-_Kr3771Y1VaJMHstSYDjLb8L7Vu++kUdev057g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Aug 4, 2022 at 11:42 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> * The comments for statext_is_compatible_clause suck. If they'd
> defined what the arguments are, perhaps this mess would have been
> prevented. For extra credit, it'd be really nice to define what
> "is compatible" means. I'd sure not have thought that that would
> include permissions checks.
I think by 'compatible' it just means the clause is in the form that can
be estimated using MCV lists. Maybe we can define it as that.
In statext_is_compatible_clause() we have the permission checks to see
if we are allowed to read all required attributes, which indeed needs to
be mentioned in the function comments.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2022-08-05 09:03:13 | Re: BUG #17570: Unrecognized node type for query with statistics on expressions |
| Previous Message | Richard Guo | 2022-08-05 00:49:30 | Re: BUG #17570: Unrecognized node type for query with statistics on expressions |