| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | zmlpostgres(at)gmail(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO |
| Date: | 2022-07-27 06:37:40 |
| Message-ID: | CAMbWs4-szteszfsO=PBSb2cizZqO6D1Gr7f-18-aD0c=LS1m6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 27, 2022 at 12:55 PM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:
> ProcessCopyOptions previously rejects force_quote_all for COPY FROM
> and copyfrom.c is not even conscious of the option (that is, even no
> assertion on it). The two options are rejected for COPY TO by the same
> function so it seems like a thinko of the commit. Getting rid of the
> code would be good in the view of code coverage and maintenance.
Yeah, ProcessCopyOptions() does have the check for force_notnull and
force_null whether it is using COPY FROM and whether it is in CSV mode.
So the codes in copyto.c processing force_notnull/force_null are
actually dead codes.
> On the otherhand I wonder if it is good that we have assertions on the
> option values.
Agree. Assertions would be better.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-07-27 06:44:25 | Re: Cygwin cleanup |
| Previous Message | Thomas Munro | 2022-07-27 06:21:07 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |